Update app.py (#65)

- Update app.py (2f5736ee56cec38610ac47204e400171c898d03b)

app.py

@@ -147,28 +147,23 @@ questions_db = {
 
 def generate_ai_questions(topic, n=5):
     """
-    Returns list of (question, options[list], correct)
-    Works ONLY in Online mode.
+    Generates n questions for a topic using Groq Chat API.
+    Returns list of (question, options, answer) tuples.
     """
+
     if not GROQ_API_KEY:
+        st.error("Groq API key not set.")
         return []
 
-    prompt = f"""
-Generate {n} multiple choice quiz questions on topic: "{topic}"
-
-Rules:
-- 4 options per question
-- One correct answer
-- JSON output ONLY
-- Format:
-[
-  {{
-    "question": "...",
-    "options": ["A","B","C","D"],
-    "answer": "A"
-  }}
-]
-"""
+    # 1) Clear instruction for Groq model
+    system_prompt = (
+        f"You are a quiz maker. Create {n} multiple‑choice questions about '{topic}'. "
+        "Respond ONLY as valid JSON in this format:\n"
+        "[\n"
+        "  {\"question\":\"...\",\"options\":[\"A\",\"B\",\"C\",\"D\"],\"answer\":\"A\"},\n"
+        "  ...\n"
+        "]"
+    )
 
     try:
         r = requests.post(
@@ -178,27 +173,55 @@ Rules:
                 "Content-Type": "application/json"
             },
             json={
-                "model": GROQ_MODEL,
-                "messages": [{"role": "user", "content": prompt}],
-                "temperature": 0.4
+                "model": "llama3‑70b‑8192",
+                "messages": [
+                    {"role": "system", "content": system_prompt},
+                    {"role": "user",   "content": topic}
+                ],
+                # Provide enough tokens for a JSON list
+                "max_tokens": 2048,
+                "temperature": 0.7
             },
             timeout=30
         )
-        data = r.json()
-        text = data["choices"][0]["message"]["content"]
-        parsed = json.loads(text)
+    except Exception as e:
+        st.error(f"Groq API request failed: {e}")
+        return []
 
-        out = []
-        for q in parsed:
-            out.append(
-                (q["question"], q["options"], q["answer"])
-            )
-        return out
+    # Check HTTP status
+    if r.status_code != 200:
+        st.error(f"Groq API error {r.status_code}: {r.text}")
+        return []
+
+    data = r.json()
 
+    # API returns text in: data["choices"][0]["message"]["content"]
+    text = ""
+    try:
+        text = data["choices"][0]["message"]["content"]
     except Exception as e:
-        print("Groq error:", e)
+        st.error(f"Unexpected Groq response format: {e}")
+        st.write(data)
         return []
 
+    # Debug: show raw response
+    st.write("Raw Groq response:", text)
+
+    # Parse JSON from text
+    try:
+        parsed = json.loads(text)
+    except json.JSONDecodeError as e:
+        st.error(f"Failed to parse JSON from Groq output: {e}")
+        return []
+
+    # Convert to tuple list
+    out = []
+    for q in parsed:
+        if "question" in q and "options" in q and "answer" in q:
+            out.append((q["question"], q["options"], q["answer"]))
+    return out
+
+
 def load_json(path, default):
     if os.path.exists(path):
         try: